Re: Patch for SonarQube code scan fixes.

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: Patch for SonarQube code scan fixes.
Дата
Msg-id CANxoLDcgZ4X05NoqaxUQCS0Sg8HxRc+adaMNbR9=6T2N3pyLUQ@mail.gmail.com
обсуждение исходный текст
Ответ на Patch for SonarQube code scan fixes.  (Nikhil Mohite <nikhil.mohite@enterprisedb.com>)
Список pgadmin-hackers
Thanks, patch applied.

On Mon, Aug 17, 2020 at 11:17 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:

1. languages:
  • Refactor this function to reduce its Cognitive Complexity from 33 to the 15 allowed.
2. foreign table:
  • Refactor this function to reduce its Cognitive Complexity from 73 to the 15 allowed.
3. schema_diff_utils:
  • Refactor this function to reduce its Cognitive Complexity from 30 to the 15 allowed.
4. schema utils:
  • Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 38 to the 15 allowed.
5. schema views:
  • Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.
6. schema diff directory_compare:
  • Refactor this function to reduce its Cognitive Complexity from 54 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu
Следующее
От: Akshay Joshi
Дата:
Сообщение: Re: [pgAdmin4][Patch] - SonarQube Issues - 14 (String literals should not be duplicated, Cognitive Complexity of functions should not be too high)