Re: [pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others
Дата
Msg-id CANxoLDcZn6timgdxUDX1Jm=usRKn2FEveF8DV=FSno3KSMuBPA@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin][RM3279] the Drop and Disconnect connection menupoints aretoo close for each others  (Rahul Shirsat <rahul.shirsat@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Rahul

Following are the review comments:
  • Priority should be set to 5 instead of 997, as the 'Remove Server' menu goes very down with that priority. 'Remove Server' menu should be near to 'Connect Server' and 'Disconnect Server'. I have tested it with 5 and it looks fine. Refer the below screenshot
                                 Screenshot 2019-11-05 at 3.27.22 PM.png   Screenshot 2019-11-05 at 3.27.38 PM.png
  • As we have renamed the menu from 'Drop Server' to 'Remove Server' we should also change the same for the below dialog when the user clicks on the menu:
                                 Screenshot 2019-11-05 at 3.16.55 PM.png
  • Please check the documentation as we renamed the menu, so we may need to change the docs.
 


On Tue, Nov 5, 2019 at 2:48 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to move "Delete/Drop" menu option away from "Disconnect Servers" for server node.

Additionally, I have renamed the "Delete/Drop" menu option to "Remove Server" for server node against issue RM3859.

--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation | Pune.


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Akshay Joshi
Дата:
Сообщение: Re: [pgAdmin][RM4895] Possible issue in reset function for nested objects
Следующее
От: Aditya Toshniwal
Дата:
Сообщение: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme