Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checksshould not be inverted, Comma operator should not be used)

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checksshould not be inverted, Comma operator should not be used)
Дата
Msg-id CANxoLDcN4R9hv-YMUHvtK4Cf0VBJS5Va2aniKpp_xAJ_qGudUw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checksshould not be inverted, Comma operator should not be used)  (Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checksshould not be inverted, Comma operator should not be used)
Список pgadmin-hackers
Дерево обсуждения
Hi Yogesh

Jasmin tests are failing, please fix and resend the patch.

On Thu, Jun 25, 2020 at 11:52 AM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi,

Please find an updated patch.


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Wed, Jun 24, 2020 at 12:31 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Yogesh

After applying your patch a new sonarqube issue has been found "Change this argument to the documented type: Number." in sqleditor_utils.js
Please fix that and resend the patch.

On Mon, Jun 22, 2020 at 4:36 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi Hackers,

Please find patch fixing sonarqube issues related to below rules - 

1.Boolean checks should not be inverted, 
2.Comma operator should not be used,
3.Arguments to built-in functions should match documented types,
4.Redundant pairs of parentheses should be removed,

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Yogesh Mahajan
Дата:
Сообщение: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executedsingle line should be denoted by indentation, A "while" loop should be usedinstead of a "for" loop, Variables should be declared explicitly)
Следующее
От: Akshay Joshi
Дата:
Сообщение: Re: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionallyexecuted single line should be denoted by indentation, A "while" loop shouldbe used instead of a "for" loop, Variables should be declared explicitly)