Re: [pgAdmin4][RM3554] Debugger scroll issue for long procedures

Hi,

Attached is the updated patch. Fixed linter issues.

On Wed, Aug 29, 2018 at 11:26 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi Aditya,

yarn run bundle gives errors.

yarn run v0.27.5

$ yarn run linter && yarn run webpacker

/home/khushboo/Projects/pgadmin4/web/pgadmin/static/bundle/codemirror.js

  20:28  error  Strings must use singlequote  quotes

  22:53  error  Strings must use singlequote  quotes

Thanks,

Khushboo

On Wed, Aug 29, 2018 at 11:10 AM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached is the latest patch and will have the following changes:

1) Debugger scrolling issues fixed. Now debugger will scroll to active line and keep the active line in the centre of the editor.

2) Changes to avoid reloading same proc/function again in case of a recursive call.

3) Found one bug where changing the preferences of Debugger to open in new tab was not working. Debugger opened in same tab. This is fixed.

Kindly review.

On Mon, Aug 27, 2018 at 7:32 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached is the updated patch which also includes code changes to avoid reloading same proc/function again in case of a recursive call.

On Mon, Aug 27, 2018 at 6:44 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Please hold on with the patch. As discussed and found by Ashesh Vashi, if we <Step In> the function called recursively then it is loading the debugger with source code again which can be avoided and will improve performance if the function is large.

Will send the updated patch along with the required changes. Thank you Ashesh.

On Mon, Aug 27, 2018 at 6:16 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached is the patch to make debugger scroll automatically to current active line and scroll along with StepIn/StepOut. Previously, we had to manually scroll.

Kindly review.

--

Thanks and Regards,

Aditya Toshniwal

Software Engineer | EnterpriseDB Software Solutions | Pune

"Don't Complain about Heat, Plant a tree"

--

Thanks and Regards,

Aditya Toshniwal

Software Engineer | EnterpriseDB Software Solutions | Pune

"Don't Complain about Heat, Plant a tree"

--

Thanks and Regards,

Aditya Toshniwal

Software Engineer | EnterpriseDB Software Solutions | Pune

"Don't Complain about Heat, Plant a tree"

--

Thanks and Regards,

Aditya Toshniwal

Software Engineer | EnterpriseDB Software Solutions | Pune

"Don't Complain about Heat, Plant a tree"

--

Thanks and Regards,

Aditya Toshniwal

Software Engineer | EnterpriseDB Software Solutions | Pune

"Don't Complain about Heat, Plant a tree"