Re: [pgAdmin4][Patch]: RM 6317 - Toggle buttons are inaccessible

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [pgAdmin4][Patch]: RM 6317 - Toggle buttons are inaccessible
Дата
Msg-id CANxoLDc3Gbrs=+0nZkKYV8X89Sm0HDqHZsDTY5tW1LDB2eaO0Q@mail.gmail.com
обсуждение исходный текст
Список pgadmin-hackers
Thanks, patch applied.

On Wed, Mar 17, 2021 at 2:36 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix the RM #6317:  Toggle buttons are inaccessible.

Our toggle buttons are not the HTML buttons but the combinations of HTML tags which function as a toggle button. As the toggle button itself doesn't have a label/title as it wrapped around a div, we have provided the extra hidden label above the toggle button div, so on receiving the focus, toggle button will read the label we provided(For example: "Can login?, Yes, Toggle. Button''), which was working as expected with Chrome Screen Reader extension, on which we have tested. Unfortunately, most screen readers like VoiceOver, NVDA etc.. read the label and the button as different tags, so when the label gets the focus, the screen reader reads it as "Can login? Yes, Toggle Button", and when we try to click it, we can't, as it is just a label. 

To fix this issue, I have put the label inside the toggle div, so the label will belong to the toggle button div itself and with the new version of Bootstrap-toggle, the role="button" is already there,  so no need to add it.

I have tested this patch on Mac with VoiceOver (on which I could reproduce the issue) and it is working fine.

After committing this patch, we need to provide the nightly build link to the author of this RM, so he can test with a Braille display.

Thanks,
Khushboo




--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Ensure that toggle buttons are accessible by most scr
Следующее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Fixed cognitive complexity reported by SonarQube.