Re: Use boolean array for nulls parameters

Поиск
Список
Период
Сортировка
От Hamid Akhtar
Тема Re: Use boolean array for nulls parameters
Дата
Msg-id CANugjhvc-ZRQ1NmGJjU0QOd8pRVYc0iuNEp-1fy_ZwWaCxk0UA@mail.gmail.com
обсуждение исходный текст
Ответ на Use boolean array for nulls parameters  (japin <japinli@hotmail.com>)
Список pgsql-hackers
Дерево обсуждения
I personally don't see any benefit in this change. The focus shouldn't be on fixing things that aren't broken. Perhaps, there is more value in using bitmap data type to keep track of NULL values, which is typical storage vs performance debate, and IMHO, it's better to err on using slightly more storage for much better performance. IIRC, the bitmap idea has previously discussed been rejected too.

On Tue, Jan 19, 2021 at 7:07 PM japin <japinli@hotmail.com> wrote:

Hi,

When I review the [1], I find that the tuple's nulls array use char type.
However there are many places use boolean array to repsent the nulls array,
so I think we can replace the char type nulls array to boolean type.  This
change will break the SPI_xxx API, I'm not sure whether this chagnges cause
other problems or not.  Any thought?

[1] - https://www.postgresql.org/message-id/flat/CA+HiwqGkfJfYdeq5vHPh6eqPKjSbfpDDY+j-kXYFePQedtSLeg@mail.gmail.com

--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.



--
Highgo Software (Canada/China/Pakistan)
URL : www.highgo.ca
ADDR: 10318 WHALLEY BLVD, Surrey, BC
CELL：+923335449950  EMAIL: mailto:hamid.akhtar@highgo.ca
SKYPE: engineeredvirus

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: Re: ResourceOwner refactoring
Следующее
От: Tom Lane
Дата:
Сообщение: Re: search_plan_tree(): handling of non-leaf CustomScanState nodes causes segfault