Thank you for your quick response! I work on greenplum, and I didn't see this folder(src/test/ssl/ssl) before.
I will add more certificates to test and resend again.
Do you have any suggestion about the missing PGDATA? Since the test needs to configure postgresql.conf, maybe there are other ways to determine this environment.
On Mon, Jul 8, 2019 at 2:59 PM Hao Wu <hawu@pivotal.io> wrote: > I see there is no test case for sslinfo. I have added a test case for it in my project.
Hi Hao Wu,
Thanks! I see that you created a CF entry https://commitfest.postgresql.org/24/2203/. While I was scanning through the current CF looking for trouble, this one popped in front of my eyes, so here's some quick feedback even though it's in the next CF:
+#!/bin/bash
I don't think we can require that script interpreter.
It looks like that's because the script assumes that PGDATA is set.
I wonder if we want to include more SSL certificates, or if we want to use the same set of fixed certificates (currently under src/test/ssl/ssl) for all tests like this. I don't have a strong opinion on that, but I wanted to mention that policy decision. (There is also a test somewhere that creates a new one on the fly.)