On Sat, 30 Apr 2022 at 12:12, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> Few comments on the patch:
> 1. I think it is better to use DatumGetUInt32 to fetch the hash key as
> the nearby code is using.
> 2. You may want to change the below comment in HSpool
> /*
> * We sort the hash keys based on the buckets they belong to. Below masks
> * are used in _hash_hashkey2bucket to determine the bucket of given hash
> * key.
> */
Addressed in new patch, v2.
On Wed, 4 May 2022 at 11:27, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> So, we should go with this unless someone else sees any flaw here.
Cool, thanks.
--
Simon Riggs http://www.EnterpriseDB.com/