On Wed, 23 Nov 2022 at 13:04, David Rowley <dgrowleyml@gmail.com> wrote:
> After getting rid of the HashInsertState code and just adding bool
> sorted to _hash_doinsert() and _hash_pgaddtup(), the resulting patch
> is much more simple:
Seems good to me and I wouldn't argue with any of your comments.
> and v4 includes 7 extra lines in hashinsert.c for the Assert() I
> mentioned in my previous email plus a bunch of extra comments.
Oh, I did already include that in v3 as requested.
> I'd rather see this solved like v4 is doing it.
Please do. No further comments. Thanks for your help
--
Simon Riggs http://www.EnterpriseDB.com/