On Wed, Dec 6, 2023 at 11:48 PM Jeff Davis <pgsql@j-davis.com> wrote:
>
> On Wed, 2023-12-06 at 07:39 +0700, John Naylor wrote:
> > "git grep cstring_hash" found nothing, so not sure what you're
> > asking.
>
> Sorry, I meant string_hash(). Your v5-0002 changes the way hashing
> works for cstrings, and that means it's no longer equivalent to
> hash_bytes with strlen. That's probably fine, but someone might assume
> that they are equivalent.
That's a good point. It might be best to leave string_hash where it is
and remove the comment that it's the default. Then the new function (I
like the name cstring_hash) can live in dynahash.c where it's obvious
what "default" means.