Re: A small problem when rehashing catalog cache

On Wed, Dec 17, 2025 at 10:35 AM Michael Paquier <michael@paquier.xyz> wrote:
> Indeed, the code bothers putting a fresh matching entry at the
> beginning of a bucket, and the code does the opposite when moving
> entries around, which is inconsistent to say the least.  If we move
> the entries at the tail instead as you are suggesting the "freshness"
> would be preserved better.  This deserves a comment, at least.
>
> 20cb18db4668 has added the RehashCatCache() part, with 473182c9523a
> copying the same pattern for RehashCatCacheLists().
>
> Thoughts or opinions from others?

I suspect it doesn't make much difference in the grand scheme of
things, but the code has to do either one thing or the other, so +1 to
do the more sensible thing.

--
John Naylor
Amazon Web Services