Hi,<br /><br />My apologies for a very late reply.<br /><br />I agree the fix you applied is a better one. I have
verifiedthe fix by testing the 'postgresql-9.1.1-1-windows-x64' installer.<br /><br />Thank you.<br /><br /><br /><div
class="gmail_quote">On Thu, Jul 14, 2011 at 7:23 PM, Magnus Hagander <span dir="ltr"><<a
href="mailto:magnus@hagander.net">magnus@hagander.net</a>></span>wrote:<br /><blockquote class="gmail_quote"
style="margin:00 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="im">On Wed, Jun 15, 2011 at 10:53,
AhmedShinwari <<a href="mailto:ahmed.shinwari@gmail.com">ahmed.shinwari@gmail.com</a>> wrote:<br /> > Hi
All,<br/> ><br /> > I faced a bug on Windows while connecting via SSPI authentication. I was<br /> > able to
findthe bug and have attached the patch. Details listed below;<br /> ><br /> > Postgres Installer: Version
9.0.4<br/> > OS: Windows Server 2008 R2/Windows 7<br /><br /></div><big snip><br /><br /> Thanks - great
analysis!<br/><br /> However, I think there is a better fix for this - simply moving a }<br /> one line. In particular,
I'mconcerned about passing the same pointer<br /> both as input and output to the function - I couldn't find anything
in<br/> the documentation saying this was safe (nor did I find anything saying<br /> it's unsafe, but.) Especially
sincethis code clearly behaves<br /> different on different versions - I've been completely unable to<br /> reproduce
thison any of my test machines, but they are all Windows<br /> Server 2003.<br /><br /> So - attached is a new version
ofthe patch, how does this look to<br /> you? FYI, I've had Thom test this new version and it does appear to<br /> work
finein his scenario.<br /><font color="#888888"><br /><br /> --<br /> Magnus Hagander<br /> Me: <a
href="http://www.hagander.net/"target="_blank">http://www.hagander.net/</a><br /> Work: <a
href="http://www.redpill-linpro.com/"target="_blank">http://www.redpill-linpro.com/</a><br /></font><br /><br /> --<br
/>Sent via pgsql-hackers mailing list (<a
href="mailto:pgsql-hackers@postgresql.org">pgsql-hackers@postgresql.org</a>)<br/> To make changes to your
subscription:<br/><a href="http://www.postgresql.org/mailpref/pgsql-hackers"
target="_blank">http://www.postgresql.org/mailpref/pgsql-hackers</a><br/><br /></blockquote></div><br /><br clear="all"
/><br/>-- <br />Ahmed Shinwari<br />EnterpriseDB Corporation : <a href="http://www.enterprisedb.com/"
target="_blank">www.enterprisedb.com</a><br/>The Enterprise Postgres Company<br /><br /><br />