On Tue, Jun 30, 2020 at 01:58:17PM +0100, Simon Riggs wrote: > On Tue, 30 Jun 2020 at 02:17, Madan Kumar <madankumar1993@gmail.com> wrote: >> It may be better to have one single function returning both >> timestamp and origin for a given transaction ID. > > No need to change existing APIs.
Adding a new function able to return both fields at the same time does not imply that we'd remove the original one, it just implies that we would be able to retrieve both fields with a single call of TransactionIdGetCommitTsData(), saving from an extra CommitTsSLRULock taken, etc. That's actually what pglogical does with its pglogical_xact_commit_timestamp_origin() in pglogical_functions.c. So adding one function able to return one tuple with the two fields, without removing the existing pg_xact_commit_timestamp() makes the most sense, no?