On 2 August 2017 at 00:56, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote:
> The patch's job is simple:
Patch no longer applies and has some strange behaviours.
> - Remove the check in the parser that causes an error the moment the
> ON CONFLICT clause is found.
Where is the check and test that blocks ON CONFLICT UPDATE?
My understanding was the patch was intended to only remove the error
in case of DO NOTHING.
> - Fix leaf partition ResultRelInfo initialization code so that the call
> ExecOpenIndices() specifies 'true' for speculative, so that the
> information necessary for conflict checking will be initialized in the
> leaf partition's ResultRelInfo
Why? There is no caller that needs information.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services