>What do you think about the attached to simplify the logic? Even if >primary_conninfo and primary_slot_name are not switched to SIGHUP this >cleanup looks like a good thing to me.
I am not convinced this is a good idea. This allows the state of walrcv and startup to diverge, they could e.g. have different configuration, due to differently time config reloads.
That sounds bad, but most parameters apply to one or the other, not both.
If there are some that apply to both, then yes, coordination would be important.
It does seem likely that the new scheme will require us to look carefully at when parameters are reloaded, since the timing of reloads was never taken into account in the previous coding.
--
Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services