Re: [COMMITTERS] pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server

Поиск
Список
Период
Сортировка
От Simon Riggs
Тема Re: [COMMITTERS] pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server
Дата
Msg-id CANP8+jJ00vg2oBWcexNVUF-q3tSNbL1PAU7ZCAs4_hFMDWe=2w@mail.gmail.com
обсуждение исходный текст
Ответы Re: [COMMITTERS] pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server  (Andres Freund <andres@anarazel.de>)
Re: [COMMITTERS] pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Дерево обсуждения
On 5 April 2016 at 01:18, Michael Paquier <michael.paquier@gmail.com> wrote:
On Mon, Apr 4, 2016 at 4:50 PM, Andres Freund <andres@anarazel.de> wrote:
> On 2016-04-04 08:44:47 +0100, Simon Riggs wrote:
>> That patch does exactly the same thing as the patch you prefer, just
>> does it differently;
>
> No, it doesn't; as explained above.

I think these few changes are all we need. (attached)
 

FWIW, I vote also for reverting this patch. This has been committed
without any real discussions..

Michael, its a shame to hear you say that, so let me give full context.

The patches under review in the CF are too invasive and not worth the trouble for such a minor problem. After full review, I would simply reject those patches (already discussed on list).

Rather than take that option, I went to the trouble of writing a patch that does the same thing but simpler, less invasive and more maintainable. Primarily, I did that for you, to avoid you having wasted your time and to allow you to backpatch a solution.

We can, if you wish, revert this patch. If we do, we will have nothing, since I object to the other patch(es).

My recommendation is that we apply the attached patch and leave it there.

--
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kyotaro HORIGUCHI
Дата:
Сообщение: Re: Support for N synchronous standby servers - take 2
Следующее
От: Fujii Masao
Дата:
Сообщение: Re: Support for N synchronous standby servers - take 2