Re: Use streaming read I/O in BRIN vacuuming

Hi,

On Thu, 9 Oct 2025 at 02:03, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> Thank you for proposing the patch! I've reviewed the patch and have
> some comments:
>
> +   stream = read_stream_begin_relation(READ_STREAM_MAINTENANCE |
> +                                       READ_STREAM_FULL |
> +                                       READ_STREAM_SEQUENTIAL |
> +                                       READ_STREAM_USE_BATCHING,
> +                                       strategy,
> +                                       idxrel,
> +                                       MAIN_FORKNUM,
> +                                       block_range_read_stream_cb,
> +                                       &p,
> +                                       0);
>
> Unlike other index AM's it uses READ_STREAM_SEQUENTIAL. If there are
> some reasons to use it, we should leave comments there.

Andres has some comments about retiring the READ_STREAM_SEQUENTIAL
flag as it is automatically detected and can potentially hurt
performance [1].

[1] https://postgr.es/m/go7c2sudqg4pp7dsabsak4ajugti4f3tyqoweja5ihcjiw65dc%40yh6wi4zqys23

-- 
Regards,
Nazir Bilal Yavuz
Microsoft