Re: meson: Optionally disable installation of test modules

Поиск
Список
Период
Сортировка
От Nazir Bilal Yavuz
Тема Re: meson: Optionally disable installation of test modules
Дата
Msg-id CAN55FZ2EmdmfBKnP3hqpkaFhEqJ-5B=c6cQ8M-1i86gf5+2vrQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: meson: Optionally disable installation of test modules  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Ответы Re: meson: Optionally disable installation of test modules  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Список pgsql-hackers
Hi,

Thanks for the review.

On Mon, 20 Feb 2023 at 21:44, Peter Eisentraut
<peter.eisentraut@enterprisedb.com> wrote:
>
> I tested this a bit.  It works fine.  The approach makes sense to me.
>
> The install_additional_files script could be simplified a bit.  You
> could use os.makedirs(dest, exist_ok=True) and avoid the error checking.
>    I don't think any callers try to copy a directory source, so the
> shutil.copytree() stuff isn't necessary.  Run pycodestyle over the
> script.  And let's put the script into src/tools/ like the other support
> scripts.
>

I updated the patch in line with your comments.

Regards,
Nazir Bilal Yavuz
Microsoft

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Nikolay Samokhvalov
Дата:
Сообщение: Re: Proposal: %T Prompt parameter for psql for current time (like Oracle has)
Следующее
От: Maciek Sakrejda
Дата:
Сообщение: Re: Proposal: %T Prompt parameter for psql for current time (like Oracle has)