Re: read stream on amcheck

Hi,

Thank you for working on this!

On Tue, 11 Feb 2025 at 21:41, Matheus Alcantara
<matheusssilv97@gmail.com> wrote:
>
> Thanks for the review! v3 with the fixes attached.

I have a small comment.

diff --git a/contrib/amcheck/verify_heapam.c b/contrib/amcheck/verify_heapam.c
index 827312306f6..8c83870db7d 100644
--- a/contrib/amcheck/verify_heapam.c
+++ b/contrib/amcheck/verify_heapam.c

+    stream = read_stream_begin_relation(READ_STREAM_SEQUENTIAL,
+                                        ctx.bstrategy,
+                                        ctx.rel,

I think we do not always want to disable prefetching by explicitly
setting the READ_STREAM_SEQUENTIAL flag. If skip_option !=
SKIP_PAGES_NONE, then the blocks might not always be sequential. So,
what do you think about setting READ_STREAM_SEQUENTIAL when the
skip_option == SKIP_PAGES_NONE and
READ_STREAM_DEFAULT otherwise.

Other than that, LGTM.

-- 
Regards,
Nazir Bilal Yavuz
Microsoft