Re: Update Windows CI Task Names: Server 2022 + VS 2022 Upgrade

Hi,

On Fri, 6 Jun 2025 at 08:30, Peter Eisentraut <peter@eisentraut.org> wrote:
>
> On 05.06.25 12:42, Thomas Munro wrote:
> > I think on your C11 thread I might have been confused about that,
> > since there was an implication that 2019 might support <stdatomic.h>,
> > but it looks like 2019 added language stuff while 2022 added the
> > library stuff.  But yeah, given your proposal that MSVC 2019 should be
> > our new minimum target on that platform, I wonder if we should have
> > both available in CI somehow...
>
> It would be useful to have a leading and a trailing edge CI system for
> every OS family.  For example, say, Ubuntu 25.04 and RHEL 7, and VS 201x
> and VS 202y.  Because as we are seeing here, sometimes you're more
> concerned about breaking the old one, and sometimes you're more
> interested in using a feature on the new one.  Maybe one of the two
> could be manually triggered to save on resources.

I have a PR [1] for installing both VS 2022 and VS 2019 to the Windows
CI image. And here is the patch for enabling both VS 2022 and VS 2019
Windows CI tasks. Since VS 2022 is the newer one, I made it triggered
automatically. VS 2019 task is manually triggered now.

Tasks have short names to select them and the 'Windows VS 2019' task's
name was 'windows'  (i.e: ci-os-only: windows) but since we have two
Windows tasks now; we need to have different names for VS 2019 and VS
2022 tasks. To preserve the same behavior, VS 2022 task uses 'windows'
but VS 2019 is renamed to 'vs2019' (i.e: ci-os-only: vs2019). I am not
completely convinced about this naming, I am open to suggestions.

Notes: This new Windows CI image is not used for now, it will be used
when this PR [1] is merged. So,

1- To test these changes, you need to apply 0001. 0001 forces CI to
use the Windows CI image with both VS versions installed. 0001 should
not be committed.

2- To avoid confusions, 0002 patch needs to be committed immediately
after 'the PR [1] is merged and the new Windows CI image is
generated'.

Example CI task after the PR is merged and 0002 is committed:
https://cirrus-ci.com/build/5976334188412928 (I manually triggered the
VS 2019 task, it will not be run automatically after the 0002 is
committed).

[1] https://github.com/anarazel/pg-vm-images/pull/116

-- 
Regards,
Nazir Bilal Yavuz
Microsoft