Re: gcc 12.1.0 warning

Поиск
Список
Период
Сортировка
От Nazir Bilal Yavuz
Тема Re: gcc 12.1.0 warning
Дата
Msg-id CAN55FZ0o9wqVoMTh_gJCmj_+4XbX9VXzQF8OySPZ0R1saxV3bA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: gcc 12.1.0 warning  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
Hi,

On Tue, 23 Apr 2024 at 19:59, Andres Freund <andres@anarazel.de> wrote:
>
>
> Which seems entirely legitimate. ISTM that guc_var_compare() ought to only
> cast the pointers to the key type, i.e. char *.  And incidentally that does
> prevent the warning.
>
> The reason it doesn't happen in newer versions of postgres is that we aren't
> using guc_var_compare() in the relevant places anymore...

The fix is attached. It cleanly applies from REL_15_STABLE to
REL_12_STABLE, fixes the warnings and the tests pass.

-- 
Regards,
Nazir Bilal Yavuz
Microsoft

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Anthonin Bonnefoy
Дата:
Сообщение: Use pgBufferUsage for block reporting in analyze
Следующее
От: Heikki Linnakangas
Дата:
Сообщение: Re: consider -Wmissing-variable-declarations