Re: Re: pglogical_output - a general purpose logical decoding output plugin

Поиск
Список
Период
Сортировка
От Craig Ringer
Тема Re: Re: pglogical_output - a general purpose logical decoding output plugin
Дата
Msg-id CAMsr+YHdxUOoiF1-0sfUC2EL5ewjhr+t64hvjoRp6x-NGjqimQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: pglogical_output - a general purpose logical decoding output plugin  (Tomasz Rybak <tomasz.rybak@post.pl>)
Список pgsql-hackers
On 19 January 2016 at 05:47, Tomasz Rybak <tomasz.rybak@post.pl> wrote:
I just quickly went through patch v5.
It's rather big patch, on (or beyond) my knowledge of PostgreSQL to perform high-quality review. But during this week I'll try to send reviews of parts of the code, as going through it in one sitting seems impossible.

One proposed change - update copyright to 2016.

i'd also propose to change of pglogical_output_control.in:
comment = 'general purpose logical decoding plugin'
to something like "general-purpoer plugin decoding and generating stream of logical changes"

We might also think about changing name of plugin to something resembling "logical_streaming_decoder" or even "logical_streamer"


I'm open to ideas there but I'd want some degree of consensus before undertaking the changes required. 



--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Steele
Дата:
Сообщение: Re: Additional role attributes && superuser review
Следующее
От: Thom Brown
Дата:
Сообщение: Re: Patch: Implement failover on libpq connect level.