Re: Refectoring of receivelog.c

Поиск
Список
Период
Сортировка
От Craig Ringer
Тема Re: Refectoring of receivelog.c
Дата
Msg-id CAMsr+YGuGhb+A_6yL_XupfG33dxj1xffhp7MhBgSufGqvW7jGg@mail.gmail.com
обсуждение исходный текст
Ответ на Refectoring of receivelog.c  (Magnus Hagander <magnus@hagander.net>)
Ответы Re: Refectoring of receivelog.c  (Magnus Hagander <magnus@hagander.net>)
Список pgsql-hackers
Дерево обсуждения
On 15 February 2016 at 04:48, Magnus Hagander <magnus@hagander.net> wrote:
I was working on adding the tar streaming functionality we talked about at the developer meeting to pg_basebackup, and rapidly ran across the issue that Andres has been complaining about for a while. The code in receivelog.c just passes an insane number of parameters around. Adding or changing even a small thing ends up touching a huge number of places.
 

Other than the lack of comments on the fields in StreamCtl to indicate their functions I think this looks good.

I didn't find any mistakes, but I do admit my eyes started glazing over after a bit.

I'd rather not have StreamCtl as a typedef of an anonymous struct if it's exposed in a header though. It should have a name that can be used in forward declarations etc.

After recently working with the XLogReader I can't emphasise enough how important *useful* comments on the fields in these sorts of structs are - the XLogReaderState has ReadRecPtr, readSegNo + readOff + readLen, currRecPtr AND latestPagePtr. Which actually do have comments, just not super helpful ones.

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kyotaro HORIGUCHI
Дата:
Сообщение: Re: pgbench - allow backslash-continuations in custom scripts
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: innocuous: pgbench does FD_ISSET on invalid socket