Re: [HACKERS] [PATCH] Fix minor race in commit_ts SLRU truncation vs lookups

Поиск
Список
Период
Сортировка
Искать
От
Craig Ringer
Тема
Re: [HACKERS] [PATCH] Fix minor race in commit_ts SLRU truncation vs lookups
Дата
Msg-id
CAMsr+YGh0dO2f3hLNXYoOq92uNPeCrrH8qC3a9S8L2UnS9RD8g@mail.gmail.com
Ответ на
Список
Дерево обсуждения
[HACKERS] [PATCH] Fix minor race in commit_ts SLRU truncation vs lookups Craig Ringer <craig@2ndquadrant.com>
Re: [HACKERS] [PATCH] Fix minor race in commit_ts SLRU truncation vslookups Petr Jelinek <petr.jelinek@2ndquadrant.com>
Re: [HACKERS] [PATCH] Fix minor race in commit_ts SLRU truncation vs lookups Craig Ringer <craig@2ndquadrant.com>
Re: [HACKERS] [PATCH] Fix minor race in commit_ts SLRU truncation vs lookups Craig Ringer <craig@2ndquadrant.com>
Re: [HACKERS] [PATCH] Fix minor race in commit_ts SLRU truncation vslookups Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: [HACKERS] [PATCH] Fix minor race in commit_ts SLRU truncation vslookups Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [HACKERS] [PATCH] Fix minor race in commit_ts SLRU truncation vs lookups Robert Haas <robertmhaas@gmail.com>
Re: [HACKERS] [PATCH] Fix minor race in commit_ts SLRU truncation vslookups Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [HACKERS] [PATCH] Fix minor race in commit_ts SLRU truncation vslookups Alvaro Herrera <alvherre@2ndquadrant.com>
On 29 December 2016 at 16:51, Craig Ringer  wrote:
> On 28 December 2016 at 22:16, Petr Jelinek  wrote:
>
>> About the patch, it looks good to me for master with the minor exception
>> that:
>>> +             appendStringInfo(buf, "pageno %d, xid %u",
>>> +                     trunc.pageno, trunc.oldestXid);
>>
>> This should probably say oldestXid instead of xid in the text description.
>
> Agreed.

Slightly amended attached.

-- 
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
В списке pgsql-hackers по дате отправления
От: Magnus Hagander
Дата:
От: Pavel Stehule
Дата:
FAQ