Re: Add PGDLLIMPORT lines to some variables

Поиск
Список
Период
Сортировка
От Craig Ringer
Тема Re: Add PGDLLIMPORT lines to some variables
Дата
Msg-id CAMsr+YFTsq-86MnsNng=mPvjjh5EAbzfMK0ptJPvzyvpFARuRg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Add PGDLLIMPORT lines to some variables  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: Add PGDLLIMPORT lines to some variables
Список pgsql-hackers
Дерево обсуждения
On 5 December 2017 at 22:49, Robert Haas <robertmhaas@gmail.com> wrote:
 

Committed with these additions.  Please check that I haven't messed anything up.


Looks good to me.

For the record the commit is

commit c572599c65bfe0387563233faabecd2845073538
Author: Robert Haas <rhaas@postgresql.org>
Date:   Tue Dec 5 09:23:57 2017 -0500

    Mark assorted variables PGDLLIMPORT.
    
    This makes life easier for extension authors who wish to support
    Windows.
    
    Brian Cloutier, slightly amended by me.
    

plus back branches.

I was going to pipe up here to add ReplicationSlotCtl to the list. Otherwise the only way to access slot information is via the SPI and pg_stat_replication_slots, which isn't super fun. And it's not like ReplicationSlotCtl is any more internal than MyReplicationSlot.

I missed the boat on your commit, but ... please?

Patches attached. MyReplicationSlot was only made PGDLLIMPORT in 9.6, so there's one for 9.4/9.5 and one for 9.6, 10, and master. Personally I don't care about 9.4/9.5 in the slightest for this, but that's where c572599c is backpatched to.

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Langote
Дата:
Сообщение: Re: [HACKERS] INSERT ON CONFLICT and partitioned tables
Следующее
От: Ashutosh Bapat
Дата:
Сообщение: Re: [HACKERS] postgres_fdw super user checks