[bugfix] commit timestamps ERROR on lookup of FrozenTransactionId

Поиск
Список
Период
Сортировка
От Craig Ringer
Тема [bugfix] commit timestamps ERROR on lookup of FrozenTransactionId
Дата
Msg-id CAMsr+YFM5Q=+ry3mKvWEqRTxrB0iU3qUSRnS28nz6FJYtBwhJg@mail.gmail.com
обсуждение исходный текст
Ответы Re: [bugfix] commit timestamps ERROR on lookup of FrozenTransactionId
Re: [bugfix] commit timestamps ERROR on lookup of FrozenTransactionId
Список pgsql-hackers
Hi all

Today I ran into an issue where commit timestamp lookups were failing with

        ERROR: cannot retrieve commit timestamp for transaction 2

which is of course FrozenTransactionId.

TransactionIdGetCommitTsData(...) ERRORs on !TransactionIdIsNormal(),
which I think is wrong. Attached is a patch to make it return 0 for
FrozenTransactionId and BootstrapTransactionId, like it does for xids
that are too old.

Note that the prior behaviour was as designed and has tests to enforce
it. I just think it's wrong, and it's also not documented.

IMO this should be back-patched to 9.6 and, without the TAP test part, to 9.5.

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Daniel Verite"
Дата:
Сообщение: Re: Improvements in psql hooks for variables
Следующее
От: Craig Ringer
Дата:
Сообщение: Re: [bugfix] commit timestamps ERROR on lookup of FrozenTransactionId