On 17 November 2016 at 00:01, Michael Paquier <michael.paquier@gmail.com> wrote:
> On Tue, Nov 15, 2016 at 11:32 PM, Noah Misch <noah@leadboat.com> wrote:
>> On Wed, Nov 16, 2016 at 12:48:03PM +0800, Craig Ringer wrote:
>>> --- a/src/test/perl/README
>>> +++ b/src/test/perl/README
>>> @@ -64,3 +64,20 @@ For available PostgreSQL-specific test methods and some example tests read the
>>> perldoc for the test modules, e.g.:
>>>
>>> perldoc src/test/perl/PostgresNode.pm
>>> +
>>> +Required Perl
>>> +-------------
>>> +
>>> +Tests must run on perl 5.8.8 and newer. perlbrew is a good way to obtain
>>
>> Tests must run on Perl 5.8.0 and newer.
Why? We've always discussed 5.8.8 before. That's already a full 10 years old.
5.8.0 is from *2002*. Are you running any 15-year-old systems you
can't update to a *patch release* of the same perl major?
gendef.pl says it needs 5.8.0 or newer with "use 5.8.0" but that's the
only relevant thing I can find, and it's not relevant to the TAP tests
anyway.
BTW, here's my older approach, with a dockerfile, before I became
aware of perlbrew:
https://www.postgresql.org/message-id/CAMsr+YGR6pU-gUyp-FT98XwXAsc9n6j-awZAqxvW_+P3RTC7cg@mail.gmail.com
5.8.8 is in CentOS 5.
Debian Lenny (6) has 5.14.2 Wheezy (5) has 5.10. Etch (4) has 5.8.8.
Etch came out in early 2007. Even Sarge had 5.8.4.
Ubuntu 10.04 Lucid (old-lts) had 5.10.1-8ubuntu2 .
So unless we care about Debian 3 Sarge or source builds done more than
10 years ago, 5.8.8 is more than good enough.
-- Craig Ringer http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services