Re: Typo patch

Поиск
Список
Период
Сортировка
От CharSyam
Тема Re: Typo patch
Дата
Msg-id CAMrLSE4HpqqhWsFr4bg0N5wvJdMxBmwbUJAQzbL9oCQXs9JxJQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Typo patch  (Heikki Linnakangas <hlinnaka@iki.fi>)
Список pgsql-hackers
<div dir="ltr">Thanks :) You make sense.</div><div class="gmail_extra"><br /><div class="gmail_quote">2015-05-21 1:49
GMT+09:00Heikki Linnakangas <span dir="ltr"><<a href="mailto:hlinnaka@iki.fi"
target="_blank">hlinnaka@iki.fi</a>></span>:<br/><blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px#ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 05/20/2015 07:29 PM, CharSyam
wrote:<br/><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br/><br /> I changed typos error. and attached patch for this.<br /> Thanks you.<br /><br /> I only changed
commentsonly<br /></blockquote><br /></div></div> Thanks, committed. Except for this one:<br /><br /> ---
src/backend/utils/sort/logtape.c<br/> +++ src/backend/utils/sort/logtape.c<br /> @@ -926,7 +926,7 @@
LogicalTapeBackspace(LogicalTapeSet*lts, int tapenum, size_t size)<br />  /*<br />   * Seek to an arbitrary position in
alogical tape.<br />   *<br /> - * *Only* a frozen-for-read tape can be seeked.<br /> + * *Only* a frozen-for-read tape
canbe sought.<br />   *<br />   * Return value is TRUE if seek successful, FALSE if there isn't that much<br />   *
datain the tape (in which case there's no state change).<br /><br /> It's true that the past tense of "seek" is
"sought",but it feels a bit weird to me in this context. This is a comment on a function called "<blah
blah>seek",and it's not clear to me that it should conjugate like the normal "seek" verb.<span class="HOEnZb"><font
color="#888888"><br/><br /> - Heikki<br /><br /></font></span></blockquote></div><br /></div> 

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: Re: Typo patch
Следующее
От: Andres Freund
Дата:
Сообщение: Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0