Re: LWLock deadlock and gdb advice

Поиск

Список

Период

Сортировка

От	Jeff Janes
Тема	Re: LWLock deadlock and gdb advice
Дата	16 июля 2015 г. 10:03:16
Msg-id	CAMkU=1x1pu1Kq_6sGnP09jZ38VCGrDUCx3KCfaNQiAqREk3aTw@mail.gmail.com обсуждение исходный текст
Ответ на	Re: LWLock deadlock and gdb advice (Heikki Linnakangas <hlinnaka@iki.fi>)
Ответы	Re: LWLock deadlock and gdb advice (Jeff Janes <jeff.janes@gmail.com>) Re: LWLock deadlock and gdb advice (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Список	pgsql-hackers

Дерево обсуждения

On Wed, Jul 15, 2015 at 8:44 AM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:

Both. Here's the patch.

Previously, LWLockAcquireWithVar set the variable associated with the lock atomically with acquiring it. Before the lwlock-scalability changes, that was straightforward because you held the spinlock anyway, but it's a lot harder/expensive now. So I changed the way acquiring a lock with a variable works. There is now a separate flag, LW_FLAG_VAR_SET, which indicates that the current lock holder has updated the variable. The LWLockAcquireWithVar function is gone - you now just use LWLockAcquire(), which always clears the LW_FLAG_VAR_SET flag, and you can call LWLockUpdateVar() after that if you want to set the variable immediately. LWLockWaitForVar() always waits if the flag is not set, i.e. it will not return regardless of the variable's value, if the current lock-holder has not updated it yet.

I ran this for a while without casserts and it seems to work. But with casserts, I get failures in the autovac process on the GIN index.

I don't see how this is related to the LWLock issue, but I didn't see it without your patch. Perhaps the system just didn't survive long enough to uncover it without the patch (although it shows up pretty quickly). It could just be an overzealous Assert, since the casserts off didn't show problems.

bt and bt full are shown below.

Cheers,

Jeff

#0 0x0000003dcb632625 in raise () from /lib64/libc.so.6

#1 0x0000003dcb633e05 in abort () from /lib64/libc.so.6

#2 0x0000000000930b7a in ExceptionalCondition (

conditionName=0x9a1440 "!(((PageHeader) (page))->pd_special >= (__builtin_offsetof (PageHeaderData, pd_linp)))", errorType=0x9a12bc "FailedAssertion",

fileName=0x9a12b0 "ginvacuum.c", lineNumber=713) at assert.c:54

#3 0x00000000004947cf in ginvacuumcleanup (fcinfo=0x7fffee073a90) at ginvacuum.c:713

#4 0x000000000093b53a in FunctionCall2Coll (flinfo=0x7fffee073e60, collation=0, arg1=140737186840448, arg2=0) at fmgr.c:1323

#5 0x00000000004d5c7a in index_vacuum_cleanup (info=0x7fffee073f80, stats=0x0) at indexam.c:717

#6 0x0000000000664f69 in lazy_cleanup_index (indrel=0x7faafbcace20, stats=0x0, vacrelstats=0x28809c8) at vacuumlazy.c:1400

#7 0x0000000000664142 in lazy_scan_heap (onerel=0x7faafbcab6d0, vacrelstats=0x28809c8, Irel=0x2881090, nindexes=2, scan_all=1 '\001') at vacuumlazy.c:1111

#8 0x0000000000662905 in lazy_vacuum_rel (onerel=0x7faafbcab6d0, options=65, params=0x286ea00, bstrategy=0x286ea90) at vacuumlazy.c:247

#9 0x00000000006623e4 in vacuum_rel (relid=16409, relation=0x7fffee074550, options=65, params=0x286ea00) at vacuum.c:1377

#10 0x0000000000660bea in vacuum (options=65, relation=0x7fffee074550, relid=16409, params=0x286ea00, va_cols=0x0, bstrategy=0x286ea90, isTopLevel=1 '\001')

at vacuum.c:295

#11 0x000000000075caa9 in autovacuum_do_vac_analyze (tab=0x286e9f8, bstrategy=0x286ea90) at autovacuum.c:2811

#12 0x000000000075be67 in do_autovacuum () at autovacuum.c:2331

#13 0x000000000075ac1c in AutoVacWorkerMain (argc=0, argv=0x0) at autovacuum.c:1648

#14 0x000000000075a84d in StartAutoVacWorker () at autovacuum.c:1455

#15 0x000000000076f745 in StartAutovacuumWorker () at postmaster.c:5261

#16 0x000000000076effd in sigusr1_handler (postgres_signal_arg=10) at postmaster.c:4918

#17 <signal handler called>

#18 0x0000003dcb6e1353 in __select_nocancel () from /lib64/libc.so.6

#19 0x000000000076a8f0 in ServerLoop () at postmaster.c:1582

#20 0x000000000076a141 in PostmasterMain (argc=4, argv=0x27b2cf0) at postmaster.c:1263

#21 0x00000000006c1e6e in main (argc=4, argv=0x27b2cf0) at main.c:223

#0 0x0000003dcb632625 in raise () from /lib64/libc.so.6

No symbol table info available.

#1 0x0000003dcb633e05 in abort () from /lib64/libc.so.6

No symbol table info available.

#2 0x0000000000930b7a in ExceptionalCondition (

conditionName=0x9a1440 "!(((PageHeader) (page))->pd_special >= (__builtin_offsetof (PageHeaderData, pd_linp)))", errorType=0x9a12bc "FailedAssertion",

fileName=0x9a12b0 "ginvacuum.c", lineNumber=713) at assert.c:54

No locals.

#3 0x00000000004947cf in ginvacuumcleanup (fcinfo=0x7fffee073a90) at ginvacuum.c:713

buffer = 186

page = 0x7faafc565b20 ""

info = 0x7fffee073f80

stats = 0x2880858

index = 0x7faafbcace20

needLock = 1 '\001'

npages = 22569

blkno = 12025

totFreePages = 11502

ginstate = {index = 0x7faafbcace20, oneCol = 1 '\001', origTupdesc = 0x7faafbcad150, tupdesc = {0x7faafbcad150, 0x0 <repeats 31 times>},

compareFn = {{fn_addr = 0x90224d <bttextcmp>, fn_oid = 360, fn_nargs = 2, fn_strict = 1 '\001', fn_retset = 0 '\000', fn_stats = 2 '\002',