On Tue, Jan 22, 2013 at 9:29 PM, Jeff Janes <
jeff.janes@gmail.com> wrote:
> On Tuesday, January 22, 2013, Tom Lane wrote:
>>
>>
>> So what we need on Windows is for the data transfer thread to notice
>> when "Log_RotationSize > 0 && ftell(syslogFile) >= Log_RotationSize",
>> and then either signal the control thread to wake up, or do the
>> rotation itself. Probably the former is less risk.
>>
>> I'm not coding this fix though, since I'm not in a position to test it.
>
>
> If I can follow though on Andrew Dunstan's instructions to get mingw up and
> running, I'll take it for a spin.
The attached patch fixes the problem, tested under mingw.
I've included an elog "JJ logger woke up" in the patch to verify that the wake up is not happening more often than it should. Obviously this line should not be included in the actual commit--but I thought a tester would like to see how I verified this.
This is my first effort in both Windows and in the Latch code, so committer beware.
It should be applied to 9_2 and to head.
I've not added it to the commit-fest as it is a bug fix.
Cheers,
Jeff