Re: Allowing line-continuation in pgbench custom scripts

Поиск
Список
Период
Сортировка
От Jeff Janes
Тема Re: Allowing line-continuation in pgbench custom scripts
Дата
Msg-id CAMkU=1wLSMBDY0YoxZH+weMS3Mjm6d1YphPoFi4jjAo10k0Yig@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Allowing line-continuation in pgbench custom scripts  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Allowing line-continuation in pgbench custom scripts
Список pgsql-hackers
On Monday, May 26, 2014, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Amit Langote <amitlangote09@gmail.com> writes:
> In a custom pgbench script, it seems convenient to be able to split a
> really long query to span multiple lines using an escape character
> (bash-style). Attached adds that capability to read_line_from_file()
> in pgbench.c

This seems pretty likely to break existing scripts that happen to contain
backslashes.  Is it really worth the compatibility risk?

Do you mean due to the bugs you point out, or in general?  Is it really at all likely that someone has ended a line of their custom benchmark file with a backslash?  I'm having a hard time seeing what, other than malice, would prod someone to do that.

Cheers,

Jeff

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD
Следующее
От: Matteo Beccati
Дата:
Сообщение: Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD