Richard Guo <guofenglinux@gmail.com> writes: > It seems that in this case the top_plan does not have any extParam, so > the Gather node that is added atop the top_plan does not have a chance > to get its initParam filled in set_param_references().
Oh, so maybe we'd need to copy up extParam as well? But it's largely moot, since I don't see a good way to avoid breaking the EXPLAIN output.
Yeah, seems breaking the EXPLAIN output is inevitable if we move the initPlans to the Gather node. So maybe we need to keep the logic as in v1 patch, i.e. avoid adding a Gather node when top_plan has initPlans. If we do so, I wonder if we need to explain the potential wrong results issue in the comments.