Re: Eager aggregation, take 3

On Sat, Oct 4, 2025 at 5:03 AM Matheus Alcantara
<matheusssilv97@gmail.com> wrote:
> I've disabled the cassert and executed the ANALYZE again before
> benchmarking and now I have similar results with a improvement on eager
> aggregate version:
>
> -- master
> Planning Time: 2.734 ms
> Execution Time: 5238.128 ms
>
> -- patched
> Planning Time: 2.578 ms
> Execution Time: 4732.584 ms

Great!

> The performance results look good to me. I don't have to much comments
> about the code although I'm still learning about the planner internals
> this patch seems in good shape to me.

Thanks for running the benchmark and reviewing the patch.

> I'm just attaching a new csv with the last results after running with
> cassert disabled and after executing ANALYZE. It looks good to me.

Yeah, the results look good this time.  There are no performance
regressions; on the contrary, several queries actually show very
really nice improvements.

- Richard