Re: [pg_rewind] use the passing callback instead of global function

Поиск
Список
Период
Сортировка
От Richard Guo
Тема Re: [pg_rewind] use the passing callback instead of global function
Дата
Msg-id CAMbWs48AGydD=q2WP8kVD+XoBRxNyF7MfyRejB9y51DS33RVoQ@mail.gmail.com
обсуждение исходный текст
Ответ на [pg_rewind] use the passing callback instead of global function  (Junwang Zhao <zhjwpku@gmail.com>)
Ответы Re: [pg_rewind] use the passing callback instead of global function
Список pgsql-hackers
Дерево обсуждения

On Wed, Apr 26, 2023 at 9:51 AM Junwang Zhao <zhjwpku@gmail.com> wrote:
`local_traverse_files` and `libpq_traverse_files` both have a
callback parameter but instead use the global process_source_file
which is no good for function encapsulation.

Nice catch.  This should be a typo introduced by 37d2ff38.

While this patch is doing it correctly, I'm wondering that since both
kinds of source server (libpq and local) are using the same function
(i.e. process_source_file) to process source file list for
traverse_files operations, do we really need to provide a callback?  Or
will there be some kind of source server that may use different source
file processing function?

Thanks
Richard

В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Drouvot, Bertrand"
Дата:
Сообщение: Re: Add two missing tests in 035_standby_logical_decoding.pl
Следующее
От: Masahiko Sawada
Дата:
Сообщение: Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode