Re: Use outerPlanState macro instead of referring to leffttree

Поиск
Список
Период
Сортировка
От Richard Guo
Тема Re: Use outerPlanState macro instead of referring to leffttree
Дата
Msg-id CAMbWs483RVxexNQxztX0=t_qEhnWbSTN3vXB9RnxoHiuFak_XQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Use outerPlanState macro instead of referring to leffttree  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Use outerPlanState macro instead of referring to leffttree  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Дерево обсуждения

On Wed, Jul 6, 2022 at 10:48 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Typically, if one applies outerPlan() or outerPlanState() to the
wrong pointer, the mistake will become obvious upon even minimal
testing.  My concern here is more about usages in edge cases that
perhaps escape testing, for instance in the arguments of an
elog() for some nearly-can't-happen case.

Yeah, concur with that. For edge case usages maybe we can use the
local-variable style to avoid wrong-pointer mistakes.

Update the patch to include changes about righttree. But this doesn't
include changes for edge case usages. (A rough look through shows to me
that the current usages should be able to be covered by tests.)

Thanks
Richard
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pavel Stehule
Дата:
Сообщение: Re: Schema variables - new implementation for Postgres 15
Следующее
От: talk to ben
Дата:
Сообщение: Re: archive modules