Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c

Поиск
Список
Период
Сортировка
От Richard Guo
Тема Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c
Дата
Msg-id CAMbWs4-tSAcv9XMMnOTb4ELB6azc0jzZpLBn7xDiSvficEKEbQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c  (Japin Li <japinli@hotmail.com>)
Список pgsql-hackers
Дерево обсуждения

On Wed, Jun 14, 2023 at 3:47 PM Michael Paquier <michael@paquier.xyz> wrote:
On Wed, Jun 14, 2023 at 03:38:10PM +0800, Richard Guo wrote:
> +1.  BTW, it seems that GUC_UNIT_TIME is not used anywhere except in
> GUC_UNIT.  I was wondering if we can retire it, but maybe we'd better
> not.  It still indicates that we need to use time units table.

Some out-of-core code declaring custom GUCs could rely on that, so
it is better not to remove it.

I see.  Thanks for pointing that out.

Thanks
Richard

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Richard Guo
Дата:
Сообщение: Re: Avoid unncessary always true test (src/backend/storage/buffer/bufmgr.c)
Следующее
От: Nikita Malakhov
Дата:
Сообщение: Re: Pluggable toaster