Re: Remove a unused argument from qual_is_pushdown_safe

Поиск
Список
Период
Сортировка
От Richard Guo
Тема Re: Remove a unused argument from qual_is_pushdown_safe
Дата
Msg-id CAMbWs4-TBmsLwjspvLKOwXPHq=0N=O1dUWrg--8GkNBrr-G9nQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Remove a unused argument from qual_is_pushdown_safe  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Дерево обсуждения

On Mon, Nov 28, 2022 at 3:40 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Fri, Nov 25, 2022 at 04:05:13PM +0800, Richard Guo wrote:
>> I wonder if we need to revise the comment atop qual_is_pushdown_safe()
>> too which says
>>
>>  * rinfo is a restriction clause applying to the given subquery (whose RTE
>>  * has index rti in the parent query).
>>
>> since there is no 'given subquery' after we remove it from the params.

I was thinking about this point, and it seems to me that we could just
do s/the given subquery/a subquery/.  But perhaps you have a different
view on the matter?
 
I think the new wording is good.  Thanks for the change.

Thanks
Richard

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ian Lawrence Barwick
Дата:
Сообщение: Re: Understanding, testing and improving our Windows filesystem code
Следующее
От: "shiy.fnst@fujitsu.com"
Дата:
Сообщение: RE: Avoid streaming the transaction which are skipped (in corner cases)