Re: Remove useless param for create_groupingsets_path

Поиск
Список
Период
Сортировка
От Richard Guo
Тема Re: Remove useless param for create_groupingsets_path
Дата
Msg-id CAMbWs4-MWaLEVyuAO24E4w9gcshUZHGHZVQ1fFPZoB6nccSRKw@mail.gmail.com
обсуждение исходный текст
Ответ на Remove useless param for create_groupingsets_path  (XueJing Zhao <zxuejing@vmware.com>)
Ответы Reply: Remove useless param for create_groupingsets_path  (XueJing Zhao <zxuejing@vmware.com>)
Список pgsql-hackers
Дерево обсуждения

On Wed, Jun 15, 2022 at 11:33 AM XueJing Zhao <zxuejing@vmware.com> wrote:

Recently I work on grouping sets and I find the last param numGroups of create_groupingsets_path is not used.

In create_groupingsets_path we use rollup->numGroups to do cost_agg. 


Yes indeed. The param 'numGroups' was used originally when we first
introduced in create_groupingsets_path(), and then all its references
inside that function were removed and replaced with the numGroups inside
RollupData in b5635948.
 

I generate a diff.patch, which is sent as an attachment.


BTW, the patch looks weird to me that it seems operates in the inverse
direction, i.e. it's adding the param 'numGroups', not removing it.

Thanks
Richard 

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kyotaro Horiguchi
Дата:
Сообщение: Re: Remove trailing newlines from pg_upgrade's messages
Следующее
От: Kyotaro Horiguchi
Дата:
Сообщение: Re: Remove trailing newlines from pg_upgrade's messages