Re: SPI_connect, SPI_connect_ext return type

Поиск
Список
Период
Сортировка
От Stepan Neretin
Тема Re: SPI_connect, SPI_connect_ext return type
Дата
Msg-id CAMaYL5Yb=3uPOQm2gufqqSDed9Z13Ow0_NhVW1MXyoEwgrmfSQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: SPI_connect, SPI_connect_ext return type  ("David G. Johnston" <david.g.johnston@gmail.com>)
Список pgsql-hackers
Дерево обсуждения

> I'd give it decent odds since our example usage doesn't include the test.
> https://www.postgresql.org/docs/current/spi-examples.html

https://www.postgresql.org/docs/devel/trigger-example.html

> /* connect to SPI manager */
>    if ((ret = SPI_connect()) < 0)
>        elog(ERROR, "trigf (fired %s): SPI_connect returned %d", when, ret);


in this page check include in the example.
I think we need to give examples of one kind. If there is no void in the code, then there should be checks everywhere (at least in the documentation).
 What do you think about the attached patch? 
Best Regards, Stepan Neretin.

Вложения

В списке pgsql-hackers по дате отправления: