Re: [pgAdmin4][Patch] - RM #5465 - [Microsoft Edge] Mensagem de Erro Indevida

Поиск
Список
Период
Сортировка
От Yogesh Mahajan
Тема Re: [pgAdmin4][Patch] - RM #5465 - [Microsoft Edge] Mensagem de Erro Indevida
Дата
Msg-id CAMa=N=MXt_Nq+n1e2R1rBW4S6WSwVKbVxpK7-rrQmHkSjXguEg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch] - RM #5465 - [Microsoft Edge] Mensagem de Erro Indevida  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch] - RM #5465 - [Microsoft Edge] Mensagem de Erro Indevida  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Hackers,

Comparing with 18 also will create the same issue as there are multiple Edge browser versions mapped to single EdgeHTML engine versions.
Please find modified patch which will show exact detected browser version till Edge Version 40. For  Edge version < 40, error message will show  version '<44'.



Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Fri, May 29, 2020 at 11:19 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Yogesh,

Your patch will fail if the edge version is older than 39. I would suggest comparing version > 18 directly.

On Fri, May 29, 2020 at 10:57 AM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch which shows the actual Edge browser version when pgAdmin is launched Edge Version <43.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Akshay Joshi
Дата:
Сообщение: Re: Windows build system cleanup
Следующее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Fixed an issue where pgadmin detects the wrong browse