<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Oct 7, 2014 at 5:05 PM, Tom Lane <span
dir="ltr"><<ahref="mailto:tgl@sss.pgh.pa.us" target="_blank">tgl@sss.pgh.pa.us</a>></span> wrote:</div><div
class="gmail_quote"><br/></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> typedef
struct<br/> {<br />! <span class="" style="white-space:pre"> </span>char<span class="" style="white-space:pre">
</span>token[TOKMAXLEN+ 1];<span class="" style="white-space:pre"> </span>/* now always null-terminated */<br /> <span
class=""style="white-space:pre"> </span>char<span class="" style="white-space:pre"> </span>type;<br />! <span class=""
style="white-space:pre"></span>int32<span class="" style="white-space:pre"> </span>value;<br /> }
datetkn;</blockquote></div><divclass="gmail_quote"><br /></div><div class="gmail_quote">Being entirely new to this
code,"now" makes me think of the "current timestamp". I think this word can be removed to reduce ambiguity.</div><div
class="gmail_quote"><br/></div><div class="gmail_quote"><br /></div><blockquote class="gmail_quote" style="margin:0px
0px0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">+ <span
class=""style="white-space:pre"> </span>/* use strncmp so that we match truncated tokens */<br /> <span class=""
style="white-space:pre"></span>result = strncmp(key, position->token, TOKMAXLEN); </blockquote><div
class="gmail_quote"><br/></div><div class="gmail_quote">In your proposal you wanted to remove "crufty code that deals
withnon-null-terminated token strings". Is this some of that crufty code? Can it be removed?</div><div
class="gmail_quote"><br/></div><div class="gmail_quote"><br /></div><div class="gmail_quote">-- Chris</div></div></div>