Re: [pgAdmin][RM4988] Refactoring of all the SQL files used by pgAdmin4

Thanks, patch applied.

On Mon, Dec 16, 2019 at 5:40 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached patch which is related to RM4988, reduces the number of hits to edit_mode_types.sql (an expensive one).

Currently, this is query is executed for every column one by one when table properties dialog is opened. I've added edit_mode_types_bulk.sql, which will fetch the edit types for all the distinct column types used in the table in a single DB trip and use that data for each column.

Also, while generating RE-SQL for columns, edit_mode_types.sql will not be executed.

This will definitely reduce time.

Kindly review.

--

Thanks and Regards,

Aditya Toshniwal

Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246