Re: Patch for SonarQube code scan fixes.

Поиск
Список
Период
Сортировка
От Aditya Toshniwal
Тема Re: Patch for SonarQube code scan fixes.
Дата
Msg-id CAM9w-_mgC6O1Pb36F_BiG8mt5_5BRAT1XCO0etkLCO+Ux78o8A@mail.gmail.com
обсуждение исходный текст
Ответ на Patch for SonarQube code scan fixes.  (Nikhil Mohite <nikhil.mohite@enterprisedb.com>)
Ответы Re: Patch for SonarQube code scan fixes.  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Дерево обсуждения
Hi,

sqlautocomplete code is mostly inherited from the pgcli project. Changing it might create trouble in updating the code with new versions.

On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:

1. psycopg2/connection:
  • Refactor this function to reduce its Cognitive Complexity from 32 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.
2. psycopg2/server_manager:
  • Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 33 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 26 to the 15 allowed.
3. sqlautocomplete/parseutils:
  • Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed.


--
Thanks & Regards,
Nikhil Mohite
Software Engineer.
Mob.No: +91-7798364578.


--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Nikhil Mohite
Дата:
Сообщение: Patch for SonarQube code scan fixes.
Следующее
От: Dave Page
Дата:
Сообщение: Re: Patch for SonarQube code scan fixes.