Re: Patch for SonarQube UI fixes.

Поиск
Список
Период
Сортировка
От Aditya Toshniwal
Тема Re: Patch for SonarQube UI fixes.
Дата
Msg-id CAM9w-_=0Z8=f0=aycKR7CghdU99-gY_V9HVu-uTUPtS7DHb5og@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Patch for SonarQube UI fixes.  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Ответы Re: Patch for SonarQube UI fixes.
Список pgadmin-hackers
Дерево обсуждения
Hi,

On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

The patch looks good to me.
I think the dashboard.js fix is not accurate as when you return something you have to assign that value to any variable.
It's the map function which requires the return. Not necessary to assign the return value.

On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have fixed some UI related  issues of SonarQube scan.
Mainly fixes are related to removing duplicate properties in css class and few js standard syntax fixes.
PFA patch.


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Khushboo Vashi
Дата:
Сообщение: Re: Patch for SonarQube UI fixes.
Следующее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Ensure that pgadmin should be able to connect to the