Re: [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only

Поиск
Список
Период
Сортировка
От Surinder Kumar
Тема Re: [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only
Дата
Msg-id CAM5-9D_szaiOK8Ff1D5RDLTLBviMknaOV3po5Ven_pZo7g74HA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only  (Dave Page <dpage@pgadmin.org>)
Ответы Re: [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only
Список pgadmin-hackers
Дерево обсуждения
​Actually It doesn't broke anywhere, instead It runs successfully. On debugging I found that it runs the subprocess.Popen() utility but it doesn't run internally the pg_dump utitliy. On running the same command on windows cmd prompt it works.
Then on setting parameters close_fds=False and cmd_shell=True, It works.
I ran backup in Google Chrome.


On Thu, Sep 22, 2016 at 6:35 PM, Dave Page <dpage@pgadmin.org> wrote:
Can you explain what was broken exactly please? Backups work fine for
me without the patch - and whilst they also work with it, I now get an
ugly command shell window flash up which I didn't before.

On Wed, Sep 21, 2016 at 11:48 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> While working on RM1391 I found another issue 'Backup is not working on
> windows".
>
> The reason is that the process executor which uses subprocess Popen() to
> execute job fails when we pass close_fds=True and shell=False in windows.
>
> Now we are settings close_fds=False and shell=True to fix it. These settings
> are specific to windows only.
>
> Please review the attached patch.
>
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Image updates
Следующее
От: Murtuza Zabuawala
Дата:
Сообщение: PATCH: Do not display 'CREATE Script' on Server-group & Server node (pgAdmin4)