Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activitydata is not updating when server is disconnected in Dashboards

Поиск
Список
Период
Сортировка
От Surinder Kumar
Тема Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activitydata is not updating when server is disconnected in Dashboards
Дата
Msg-id CAM5-9D8dEB38wf7QKDCH6oP_omAe=RojUsfLAZcMzjGgx-2+uQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activitydata is not updating when server is disconnected in Dashboards  (Dave Page <dpage@pgadmin.org>)
Ответы Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activitydata is not updating when server is disconnected in Dashboards
Список pgadmin-hackers
Hi Dave,

On Tue, Apr 11, 2017 at 4:28 PM, Dave Page <dpage@pgadmin.org> wrote:
On Tue, Apr 11, 2017 at 10:51 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> When a server is disconnected, listen to 'pgadmin:server:disconnect'event
> and trigger refresh button of Server Activity data.

I don't see any reason to do that - it's not auto-refreshed data, so
why clear it?
​Hmm. i agree.​

> Also, on server disconnect, an unused event 'server-disconnected' is being
> triggered.
> instead it should trigger ''pgadmin:server:disconnect'event.
​Please find attached patch for same.​ 

Please submit that as a separate cleanup patch.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activitydata is not updating when server is disconnected in Dashboards
Следующее
От: Murtuza Zabuawala
Дата:
Сообщение: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree