[pgAdmin4][Patch]: number.toFixed is not function

Поиск
Список
Период
Сортировка
От Surinder Kumar
Тема [pgAdmin4][Patch]: number.toFixed is not function
Дата
Msg-id CAM5-9D8MNK3twAi8tnh1u-QJwg0RRH3+HHJabxue_kgRaz=dUQ@mail.gmail.com
обсуждение исходный текст
Ответы Re: [pgAdmin4][Patch]: number.toFixed is not function
Список pgadmin-hackers
Дерево обсуждения
Hi

Please find the patch
Issue:
We got the following error in console log
"number.toFixed is not function"

Steps to reproduce:
1) Click on statistics tab.
1) Select any database node.
2) then select Databases collection node.
3) The above error will appear into console.
 
Reason:
I discussed the issue with @Murtaza and here we are explicitly
converting values at server side to string as JSON do not directly
support NaN & Infinity values. Because of which NumberFormatter receives
values of type string and breaks.

Solution:
Overrides the NumberFormatter to support NaN & Infinity values.
and we need to parse the values again in float at client side.

Please review.

Thanks,
Surinder Kumar
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Ashesh Vashi
Дата:
Сообщение: pgAdmin 4 commit: Use PUBLIC (in caps) whenever used as a keyword. Fixe
Следующее
От: Murtuza Zabuawala
Дата:
Сообщение: PATCH: Allow default ACLs to be specified when creating a schema (pgAdmin4)