[pgAdmin4][Patch]: RM#1478 - Make code mirror text editor keyboard shortcuts consistent irrespective of platform type

Поиск
Список
Период
Сортировка
От Surinder Kumar
Тема [pgAdmin4][Patch]: RM#1478 - Make code mirror text editor keyboard shortcuts consistent irrespective of platform type
Дата
Msg-id CAM5-9D8ExeecjY6Mk7iZ_ZFs+iyLr1-6QtJR0djYvSO_65NtEw@mail.gmail.com
обсуждение исходный текст
Ответы Re: [pgAdmin4][Patch]: RM#1478 - Make code mirror text editor keyboard shortcuts consistent irrespective of platform type  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Дерево обсуждения
Hi

I found that Code-mirror library itself provides the List of keyboard shortcuts for Mac OSX and other platform type.
We just need to pass them in extraKeys param while creating code-mirror instance.

Following is the keyboard shortcuts for various operations in text editor:

  1. Copy -                            [Ctrl-C, Cmd-C]
  2. Cut -                               [Ctrl-X, Cmd-X]
  3. Select All -                      [Ctrl-A, Cmd-A]
  4. Undo -                            [Ctrl-Z, Cmd-Z]
  5. Redo -                            [Ctrl-Y, Cmd-Y]
  6. Delete Line -                  [Ctrl-D, Cmd-D]
  7. Move left/right(words) -  [Alt-Left, Alt-Right]
  8. Move start/end of line -  [Cmd-Left, Cmd-Right] // Ctrl-Left/Right are bound to System   shortcuts. so these keys cannot be used.
These keyboard shortcuts are consistent in Web/Runtime applications in all platform types.

Issue not fixed:
keyboard shortcut for Paste text doesn't work in Mac Runtime only. It is working on Linux runtime & Windows Runtime.
An issue "Key shortcuts doesn't work on Mac OS for QWebView widget" is also reported.

I also found that right click paste is working in Mac Runtime which is the feature of code-mirror, So I am looking into its code to figure out and I will send a patch with fix once it gets fixed.

Please find attached patch and review.


Thanks,
Surinder Kumar

Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Harshal Dhumal
Дата:
Сообщение: patch for RM1177 [pgadmin4]
Следующее
От: Surinder Kumar
Дата:
Сообщение: [pgAdmin4][Patch]: RM1524 - Reverse engineered SQL for Trigger Functions missing "AS"