Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESCfrom within a dialog box should act like "Cancel" button

Поиск
Список
Период
Сортировка
От Surinder Kumar
Тема Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESCfrom within a dialog box should act like "Cancel" button
Дата
Msg-id CAM5-9D85mNA9yGdqrZzZZ2+ko95w_Ryxv6KCQCbaTt0OMiX4dQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESCfrom within a dialog box should act like "Cancel" button  (Dave Page <dpage@pgadmin.org>)
Ответы Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESCfrom within a dialog box should act like "Cancel" button  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Дерево обсуждения
Hi Dave,

Please find updated patch.

On Mon, Jun 12, 2017 at 7:58 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> I confirm this is updated patch.

Thanks. Something else seems to have changed that I can't spot. Only
<return> should be ignored if a child control has focus - Escape and
F1 should continue to work. I tried moving the:

if (panel && panel['_type'] !== 'node_props') return;

into the branch for keyCode.ENTER, but that doesn't seem to help.
​Fixed.​

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React
Следующее
От: Shruti B Iyer
Дата:
Сообщение: Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React