Re: [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix]

Поиск
Список
Период
Сортировка
От Surinder Kumar
Тема Re: [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix]
Дата
Msg-id CAM5-9D-081KaqiSCrtup4Xnf=8rrK+B7tsd0ehCs8r_Kg9ukRA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix]  (Dave Page <dpage@pgadmin.org>)
Ответы Re: [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix]  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Дерево обсуждения
​I missed to add the check "destroy only if select2 has destroy property'. in previous patch.
It was reproducible when I select access method of exclusion constraint from combo box.

Please find attached patch and review.

On Sat, Oct 15, 2016 at 12:50 AM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.


On Friday, October 14, 2016, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi

While clicking on Select2 control, it tries to destroy the control and thus it doesn't get this object sometimes and throws error.

It should attempt to destroy the select2 object only if this object is not undefined.
Adds proper check to handle the case.

Please find minor patch and review.

Thanks
Surinder Kumar


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: PATCH: To raise an error if background job fails to start (pgAdmin4)
Следующее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Ensure steps and schedules can be created in empty jo